Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of simulated results in CHSH tutorial #1447

Merged
merged 2 commits into from
May 29, 2024
Merged

Remove mention of simulated results in CHSH tutorial #1447

merged 2 commits into from
May 29, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented May 28, 2024 •
edited by Eric-Arellano
Loading

First part of #1443

Still need to figure out how to change the tags on the platform.

  • The CHSH tutorial is tagged "scheduling", but there is no scheduling involved.

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Eric-Arellano Eric-Arellano changed the title Remove mention of simulated results Remove mention of simulated results in CHSH tutorial May 28, 2024
Eric-Arellano
Eric-Arellano approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For my own curiosity, why remove the colors?

@beckykd
Copy link
Collaborator Author

beckykd commented May 28, 2024 •
edited
Loading

Thanks! For my own curiosity, why remove the colors?

Because they're hard to see and I've seen several comments about people being confused. Since one is just dot, and one is dot-dash, I think that's good enough to identify the bounds. Does that seem reasonable?

@Eric-Arellano
Copy link
Collaborator

Eric-Arellano commented May 28, 2024 •
edited
Loading

Does that seem reasonable?

Yeah. Looking at it, even the dashes are very hard to distinguish. Thoughts on calling it the "inner lines" and "outer lines", or something?

The dashed lines and gray bars delimit the bounds; the outer-most lines delimit the quantum-bounds (math), whereas the inner lines delimit the classical bounds (math).

Screenshot 2024-05-28 at 4 36 54 PM

@beckykd
Copy link
Collaborator Author

beckykd commented May 29, 2024

The tags are being taken care of by @frankharkins

@beckykd beckykd added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit bc4c7c0 May 29, 2024
3 checks passed
@beckykd beckykd deleted the CHSH-updates branch May 29, 2024 14:42
@beckykd beckykd mentioned this pull request May 29, 2024
Closed
5 tasks
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
@beckykd
Remove mention of simulated results in CHSH tutorial (Qiskit#1447)
40dc2fb 
First part of Qiskit#1443 

Still need to figure out how to change the tags on the platform.  

- [ ] The CHSH tutorial is tagged "scheduling", but there is no
scheduling involved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Docs Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beckykd @qiskit-bot @Eric-Arellano